Repository navigation
Update events page - #696
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Events feature to support richer event metadata (location + external links) sourced from an expanded CSV schema, and adjusts navigation links accordingly.
Changes:
- Extend
data/events.csvschema and updateEventsPageViewto include location/event/blog fields and optional images. - Update the Events page template to render the new fields and handle missing images.
- Tweak navigation/footer links and add a new event image asset.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
main/views/page_views.py |
Reads new CSV columns into the Events context and sorts events by start date. |
main/templates/main/pages/events.html |
Renders new event fields (location/event/blog) and adds a “no image” placeholder. |
data/events.csv |
Replaces the old CSV layout with a new header + enriched event records. |
main/templates/main/snippets/navbar.html |
Updates the Framework dropdown label for the roles page. |
main/templates/main/snippets/footer.html |
Adds a Framework “Overview” link in the footer. |
main/static/assets/img/events/DisCouRSE -team-culture.jpg |
Adds a new event image asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anenadic
left a comment
There was a problem hiding this comment.
This is looking good to me, would nice to add slides we used at events and maybe other docs but this can also be added progressively.
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
Overall, this is good. I still think that longer term this should be moved to the database, or pulled from a separate location, like how the governance and licensing pages have been done.
Again, some changes required to make tests pass, and some good suggestions from copilot to address
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
052ac8d to
f13b727
Compare
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
I'm happy with this. I will merge it. There are a couple of things we need to do to completely finish this feature, but I think they are future work.
They are:
- Add the events into the production DB (via the admin interface). This file is compatible and matches the update to the file that @davehorsfall already made in this PR: DIRECT-Events.csv
- Enable serving media so images associated with each event can be used. This is actually quite complex and requires setting up another azure resource. So I will open another issue and we can defer this.
Description
This PR updates the existing events page, populating each event with more details.
Fixes # (issue)
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks