fix(mcp): restrict manual tool execution to admins#2755
Merged
reachjalil merged 1 commit intoJul 14, 2026
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
@reachjalil is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The manual execution endpoint used member-level authorization, so any granted workspace member could invoke an external MCP tool. These tools can perform mutating or destructive actions in connected systems, making direct manual execution an administrative diagnostic capability. The dashboard also exposed the execution control to non-admin members even though the safer boundary is admin-only.
Security boundaries
Verification
Manual verification
The authorization behavior is covered directly by focused tests: admins can execute, regular members receive 403, tenant isolation remains intact, and per-member credentials remain caller-scoped. The admin-versus-member browser visibility path was not rerun manually.
Risk and rollback
Regular members can still inspect the tool catalogs granted to them, but they can no longer execute tools manually. Reverting the single commit restores the previous member-level execution behavior.