feat: support unbounded 2-tuples in `Storable` by ielashi · Pull Request #437 · dfinity/stable-structures

ielashi · 2026-04-22T13:37:48Z

Previously encoding (A, B) tuple with Storable was only possible if A and B are Bounded. This commit extends that support to allow A and B to be Unbounded.

github-actions · 2026-04-22T13:49:55Z

`canbench` 🏋 (dir: ./benchmarks/btreemap) `1d01ed5` 2026-04-22 13:47:58 UTC

✅ ./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 252 | regressed 0 | improved 0 | new 0 | unchanged 252]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 252 | regressed 0 | improved 0 | new 0 | unchanged 252]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 252 | regressed 0 | improved 0 | new 0 | unchanged 252]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-22T13:49:55Z

`canbench` 🏋 (dir: ./benchmarks/vec) `1d01ed5` 2026-04-22 13:46:48 UTC

✅ ./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-22T13:49:55Z

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `1d01ed5` 2026-04-22 13:46:50 UTC

✅ ./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-22T13:49:56Z

`canbench` 🏋 (dir: ./benchmarks/io_chunks) `1d01ed5` 2026-04-22 13:47:25 UTC

✅ ./benchmarks/io_chunks/canbench_results.yml is up to date
📦 canbench_results_io_chunks.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-22T13:49:56Z

`canbench` 🏋 (dir: ./benchmarks/btreeset) `1d01ed5` 2026-04-22 13:46:56 UTC

✅ ./benchmarks/btreeset/canbench_results.yml is up to date
📦 canbench_results_btreeset.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-22T13:49:59Z

`canbench` 🏋 (dir: ./benchmarks/nns) `1d01ed5` 2026-04-22 13:47:02 UTC

✅ ./benchmarks/nns/canbench_results.yml is up to date
📦 canbench_results_nns.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max +2.83M | p75 +146.70K | median +37 | p25 0 | min 0]
    change %: [max +0.11% | p75 +0.05% | median 0.01% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

maksymar · 2026-04-22T14:16:07Z

hi Islam, I just recently asked Louis to revert the same PR here: #436.
not because of the implementation, but because of the correct release procedure, just to make sure we are not releasing a silent footgun.

ielashi added 2 commits April 22, 2026 15:30

feat: support unbounded 2-tuples

d5b1019

.

0436d80

ielashi requested a review from a team as a code owner April 22, 2026 13:37

ielashi requested a review from lpahlavi April 22, 2026 13:37

.

c994c79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support unbounded 2-tuples in `Storable`#437

feat: support unbounded 2-tuples in `Storable`#437
ielashi wants to merge 3 commits intomainfrom
ielashi/implement-2-tuples

ielashi commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

maksymar commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ielashi commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/btreemap) 1d01ed5 2026-04-22 13:47:58 UTC

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/vec) 1d01ed5 2026-04-22 13:46:48 UTC

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/memory_manager) 1d01ed5 2026-04-22 13:46:50 UTC

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/io_chunks) 1d01ed5 2026-04-22 13:47:25 UTC

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/btreeset) 1d01ed5 2026-04-22 13:46:56 UTC

Uh oh!

github-actions Bot commented Apr 22, 2026

canbench 🏋 (dir: ./benchmarks/nns) 1d01ed5 2026-04-22 13:47:02 UTC

Uh oh!

maksymar commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`canbench` 🏋 (dir: ./benchmarks/btreemap) `1d01ed5` 2026-04-22 13:47:58 UTC

`canbench` 🏋 (dir: ./benchmarks/vec) `1d01ed5` 2026-04-22 13:46:48 UTC

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `1d01ed5` 2026-04-22 13:46:50 UTC

`canbench` 🏋 (dir: ./benchmarks/io_chunks) `1d01ed5` 2026-04-22 13:47:25 UTC

`canbench` 🏋 (dir: ./benchmarks/btreeset) `1d01ed5` 2026-04-22 13:46:56 UTC

`canbench` 🏋 (dir: ./benchmarks/nns) `1d01ed5` 2026-04-22 13:47:02 UTC