refactor(fe): one queue for authorization-bearing requests - #4269
Open
sea-snake wants to merge 4 commits into
Open
refactor(fe): one queue for authorization-bearing requests#4269sea-snake wants to merge 4 commits into
sea-snake wants to merge 4 commits into
Conversation
sea-snake
added
the
feature:revocable-app-sessions
sea-snake
marked this pull request as ready for review
August 22, 2026 18:16
|
✅ No security or compliance issues detected. Reviewed everything up to 05580cb. Security Overview
Detected Code Changes
|
sea-snake
force-pushed
the
fe/authorization-request-queue
branch
from
August 22, 2026 18:45
55d30b3 to
0c845ae
Compare
sea-snake
force-pushed
the
fe/authorization-request-queue
branch
from
August 22, 2026 19:07
0c845ae to
df54c97
Compare
sea-snake
force-pushed
the
fe/authorization-request-queue
branch
from
August 22, 2026 19:25
df54c97 to
9d2f6d5
Compare
The delegation handler serialised its own requests so two consent screens could not race. A second handler that also authorizes is coming, and it has to share that queue rather than keep its own: two queues would let one request paint over the other's screen. Lifts the queue into `serialize.ts` as `serializeAuthorizationRequest`, with no change to what the delegation handler does with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sea-snake
force-pushed
the
fe/authorization-request-queue
branch
from
August 22, 2026 19:49
9d2f6d5 to
d67df85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design: #4224. Overview: #4230. Groundwork for #4273, which is the second caller.
The delegation handler serialises its own requests so that two consent screens cannot race. The session handler coming in #4273 also authorizes, and it has to share that queue rather than keep one of its own — two queues would let one request paint over the other's screen.
Lifts the queue out of the delegation handler into
serialize.tsasserializeAuthorizationRequest. No change to what the delegation handler does with it.No tests:
handleDelegationRequesthas no unit coverage today, and the extracted function is a move of the existing queue. Its first test arrives with the second caller in #4273.