feat(governance): Store snapshot ID in TakeCanisterSnapshot proposals.#9998
Merged
daniel-wong-dfinity-org merged 7 commits intomasterfrom Apr 24, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
- Done.
- Not breaking: new variant arm, and the one field that use the variant use
opt. - Existing proposals and neurons are fine. No backfill.
- Seems low risk.
jasonz-dfinity
approved these changes
Apr 23, 2026
daniel-wong-dfinity-org
force-pushed
the
store-snapshot-id-in-proposal-daniel-wong
branch
from
cafb776 to
6676694
Compare
…tead, the destination type is Option<api::...>.
daniel-wong-dfinity-org
deleted the
store-snapshot-id-in-proposal-daniel-wong
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of a field that was introduced recently:
successful_value. Prior to this, there was no good way of knowing the ID of the snapshot.Limitation: this does not work when Governance is being snapshotted. This is because snapshotting is executed asynchronously in this case; the proposal is marked as "Successful" once snapshottting is LAUNCHED, not when it has completed successfully. The reason for async is to avoid deadlock.
References
Closes NNS1-4339.