fix: Fix remaining race on the var crypt device#9984
Open
fix: Fix remaining race on the var crypt device#9984
Conversation
This device flaps during setup, so do not bind to avoid the mount from quickly being unmounted.
The var.mount unit pulls this into the transaction at the same time it does fsck, but it does not hurt to be explicit.
Bownairo
force-pushed
the
eero/no-bind-var
branch
from
69eecf7 to
536c789
Compare
Bownairo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This device flaps during setup, so do not bind to avoid the mount from quickly being unmounted.
This was seen in some flaky tests here. With the fix, we do not see the issue once out of 100 runs.