ACME changes - #111
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ACME DNS challenge handling to remove specific tokens and adds IC DNS LB support.
Changes:
- Tracks and cleans up exact
(zone, token)pairs. - Adds Cloudflare and IC DNS LB backend tests.
- Updates Pebble test binaries and TLS test dependencies.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
ic-bn-lib/tools/cloudflare-test.rs |
Uses targeted record deletion. |
ic-bn-lib/src/tls/acme/mod.rs |
Updates token APIs and backend types. |
ic-bn-lib/src/tls/acme/dns/mod.rs |
Updates DNS deletion and test helpers. |
ic-bn-lib/src/tls/acme/dns/ic_dns_lb.rs |
Adds the IC DNS LB backend. |
ic-bn-lib/src/tls/acme/dns/cloudflare.rs |
Implements content-specific deletion and tests. |
ic-bn-lib/src/tls/acme/client.rs |
Tracks tokens and performs best-effort cleanup. |
ic-bn-lib/src/tests/pebble.rs |
Updates Pebble binaries and arguments. |
ic-bn-lib/Cargo.toml |
Enables Rustls for test servers. |
Cargo.lock |
Records TLS feature dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bownairo
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenManager&DnsManagertraits to require specifying which token to unset/delete, instead of removing everything(zone, token)tuples to clean them up after certificate issuance or an errorIcDnsLbimplementation ofDnsManagertrait that usesic-dns-lbas a DNS backend to set ACME challengespebble&pebble-challtestsrvACME integration test binaries to the latest version