Skip to content

ACME changes - #111

Merged
blind-oracle merged 12 commits into
mainfrom
igor/acme-updates
Aug 11, 2026
Merged

ACME changes#111
blind-oracle merged 12 commits into
mainfrom
igor/acme-updates

Conversation

@blind-oracle

Copy link
Copy Markdown
Contributor
  • API-breaking: change TokenManager & DnsManager traits to require specifying which token to unset/delete, instead of removing everything
  • Fix all trait implementations to account for the above
  • Fix ACME client to collect (zone, token) tuples to clean them up after certificate issuance or an error
  • Add IcDnsLb implementation of DnsManager trait that uses ic-dns-lb as a DNS backend to set ACME challenges
  • Add integration test to Cloudflare/ic-dns-lb backends
  • Updates pebble & pebble-challtestsrv ACME integration test binaries to the latest version

@blind-oracle
blind-oracle requested a review from a team as a code owner August 10, 2026 20:21
@blind-oracle
blind-oracle requested a balanced review from Copilot August 10, 2026 20:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ACME DNS challenge handling to remove specific tokens and adds IC DNS LB support.

Changes:

  • Tracks and cleans up exact (zone, token) pairs.
  • Adds Cloudflare and IC DNS LB backend tests.
  • Updates Pebble test binaries and TLS test dependencies.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
ic-bn-lib/tools/cloudflare-test.rs Uses targeted record deletion.
ic-bn-lib/src/tls/acme/mod.rs Updates token APIs and backend types.
ic-bn-lib/src/tls/acme/dns/mod.rs Updates DNS deletion and test helpers.
ic-bn-lib/src/tls/acme/dns/ic_dns_lb.rs Adds the IC DNS LB backend.
ic-bn-lib/src/tls/acme/dns/cloudflare.rs Implements content-specific deletion and tests.
ic-bn-lib/src/tls/acme/client.rs Tracks tokens and performs best-effort cleanup.
ic-bn-lib/src/tests/pebble.rs Updates Pebble binaries and arguments.
ic-bn-lib/Cargo.toml Enables Rustls for test servers.
Cargo.lock Records TLS feature dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ic-bn-lib/src/tls/acme/dns/ic_dns_lb.rs Outdated
Comment thread ic-bn-lib/src/tests/pebble.rs
Comment thread ic-bn-lib/src/tls/acme/dns/ic_dns_lb.rs Outdated
Comment thread ic-bn-lib/src/tls/acme/dns/cloudflare.rs
Comment thread ic-bn-lib/src/tls/acme/dns/ic_dns_lb.rs
@blind-oracle
blind-oracle merged commit 7f57dcc into main Aug 11, 2026
6 checks passed
@blind-oracle
blind-oracle deleted the igor/acme-updates branch August 11, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants