feat: introduce InsertionOrderedSet for monitored_accounts#178
Open
feat: introduce InsertionOrderedSet for monitored_accounts#178
InsertionOrderedSet for monitored_accounts#178Conversation
lpahlavi
changed the title
InsertionOrderedSet for monitored_accounts
Replace `monitored_accounts: BTreeSet<Account>` with a new `InsertionOrderedSet<Account>` that preserves insertion order. The set is backed by `InsertionOrderedMap<K, ()>` and exposes only the methods needed at call sites: `insert`, `remove`, `contains`, `len`, and `iter`. Call sites in `deposit::automatic` are unchanged because `InsertionOrderedSet` intentionally mirrors `BTreeSet`'s API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lpahlavi
force-pushed
the
lpahlavi/defi-2780-insertion-ordered-set
branch
from
31bb588 to
d653a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InsertionOrderedSet<K>in a newutils::insertion_ordered_setmodule, backed byInsertionOrderedMap<K, ()>insert,remove,contains,len, anditermonitored_accounts: BTreeSet<Account>withInsertionOrderedSet<Account>to preserve insertion order, enabling fair round-robin pollingInsertionOrderedSetdeliberately mirrorsBTreeSet's API (contains,iter, etc.) so no call sites indeposit::automaticneed to change.🤖 Generated with Claude Code