feat: mint accepted automatic deposits#177
Draft
lpahlavi wants to merge 1 commit intolpahlavi/defi-2780-process-signatures-queuefrom
Draft
feat: mint accepted automatic deposits#177lpahlavi wants to merge 1 commit intolpahlavi/defi-2780-process-signatures-queuefrom
lpahlavi wants to merge 1 commit intolpahlavi/defi-2780-process-signatures-queuefrom
Conversation
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
2 times, most recently
from
c03a2cc to
691066e
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
2 times, most recently
from
7aed2a6 to
764c2c0
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
2 times, most recently
from
e41c91c to
7d35feb
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
from
764c2c0 to
0d23e9f
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
from
7d35feb to
9600ad8
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
from
0d23e9f to
65c11e1
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
from
9600ad8 to
d22faad
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
2 times, most recently
from
b01b52d to
68f920d
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
from
d22faad to
d27a8ba
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
from
68f920d to
40a089d
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
from
d27a8ba to
bad6704
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
from
40a089d to
cf7c2dc
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-process-signatures-queue
branch
from
bad6704 to
8b26721
Compare
Implements the `mint_automatic_deposits` timer that drains the `accepted_deposits` map and mints ckSOL for each entry via `icrc1_transfer` to the ledger. Adds a full end-to-end integration test (`should_automatically_mint_deposit`) verifying that `update_balance` → poll → signature processing → minting results in the correct ckSOL balance for the depositor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lpahlavi
force-pushed
the
lpahlavi/defi-2780-mint-automatic-deposits
branch
from
cf7c2dc to
d7901c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mint_automatic_depositstimer that drains theaccepted_depositsmap and mints ckSOL viaicrc1_transferfor each accepted automatic depositsetup_timers()with a 5-second intervalmint_automatic_deposits_testsunit tests (3 tests: happy path, mint failure keeps deposit for retry, no-op when empty)should_automatically_mint_depositintegration test verifying the full end-to-end automatic deposit flow:update_balance→ poll (getSignaturesForAddress) → signature processing (getTransaction) → minting → correct ckSOL balanceStacks on: #176 (process signatures queue and accept automatic deposits)
Test plan
should_automatically_mint_depositintegration test end-to-end🤖 Generated with Claude Code