Open
Conversation
While we're at it, fix a use-after-free for abs_filename.
Comment on lines
+36
to
+37
| char fakechroot_abspath[FAKECHROOT_PATH_MAX]; | ||
| char fakechroot_buf[FAKECHROOT_PATH_MAX]; |
There was a problem hiding this comment.
What's the point of adding two statically allocated string variables and not using them at all?
There was a problem hiding this comment.
Nevermind, I looked at the expand_chroot_path() macro and it uses these two for the expansion. A non-obvious approach, but I guess we work with what we've got :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of effort to port
fakechrootto musl libc in https://github.com/dex4er/fakechroot/compare/master...sgn:musl-port?expand=1The port isn't usable yet (
cp.tis failing).Those 2 changes should be good with other libc, hence I would like to have them merged first.