chore: Provide ability to configure backup job retry limit in DevWorkspaceOperatorConfig

[tolusha]

What does this PR do?

Provide ability to configure backup job retry limit in DevWorkspaceOperatorConfig

What issues does this PR fix or reference?

#1579

Is it tested? How?

TODO

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[rohanKanojia]

The Validate PRs/ Check sources GitHub job failure is not related to changes added in this PR.

I've raised a PR to fix it #1589 . Build should pass once that PR is merged and this PR is rebased.

[dkwon17]

Thank you @rohanKanojia , #1589 is now merged.

@tolusha could you please rebase?

[dkwon17]

LGTM, but could we also add this change in this PR?

diff --git a/pkg/config/sync.go b/pkg/config/sync.go
index 3be99586..5e62600a 100644
--- a/pkg/config/sync.go
+++ b/pkg/config/sync.go
@@ -760,9 +760,20 @@ func GetCurrentConfigString(currConfig *controller.OperatorConfiguration) string
                        }
 
                        if workspace.BackupCronJob.Schedule != defaultConfig.Workspace.BackupCronJob.Schedule {
-                               config = append(config, fmt.Sprintf("workspace.backupCronJob.cronJobScript=%s", workspace.BackupCronJob.Schedule))
+                               config = append(config, fmt.Sprintf("workspace.backupCronJob.schedule=%s", workspace.BackupCronJob.Schedule))
+                       }
+                       if workspace.BackupCronJob.Registry != nil {
+                               config = append(config, fmt.Sprintf("workspace.backupCronJob.registry.path=%s", workspace.BackupCronJob.Registry.Path))
+                               config = append(config, fmt.Sprintf("workspace.backupCronJob.registry.authSecret=%s", workspace.BackupCronJob.Registry.AuthSecret))
+                       }
+                       if workspace.BackupCronJob.OrasConfig != nil {
+                               if workspace.BackupCronJob.OrasConfig.ExtraArgs != "" {
+                                       config = append(config, fmt.Sprintf("workspace.backupCronJob.orasConfig.extraArgs=%s", workspace.BackupCronJob.OrasConfig.ExtraArgs))
+                               }
+                       }
+                       if workspace.BackupCronJob.BackoffLimit != nil && *workspace.BackupCronJob.BackoffLimit != *defaultConfig.Workspace.BackupCronJob.BackoffLimit {
+                               config = append(config, fmt.Sprintf("workspace.backupCronJob.backoffLimit=%d", *workspace.BackupCronJob.BackoffLimit))
                        }
-
                }
                if workspace.HostUsers != nil {
                        config = append(config, fmt.Sprintf("workspace.hostUsers=%t", *workspace.HostUsers))
(END)

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia, tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rohanKanojia]

I tested and can confirm this PR correctly sets backoffLimit as configured in the created Job.

However, I observe that on failure backup controller is creating new jobs on failure. In my opinion, the backup controller should only create a NEW Job once the previous Job has completely finished (success or exhausted all retries)

Edit: This behavior was because I had set backup cronjob schedule to 1 minute.