refactor: reader readability and typing cleanups - #145
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hrodmn
approved these changes
Aug 18, 2026
hrodmn
left a comment
Contributor
There was a problem hiding this comment.
Thanks @maxrjones, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies some minor cleanup to the reader module. Primarily, the
try...exceptblocks might imply to a developer that these are optional dependencies, when in fact they are required by the library, and removing unnecessary nesting for readability.Testing
I ran the test suite locally.
PR checks
run-cdk-checkslabel to this PR.deploy-devlabel. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.