Skip to content

refactor: reader readability and typing cleanups - #145

Merged
maxrjones merged 2 commits into
developmentseed:mainfrom
maxrjones:refactor/cleanups
Aug 18, 2026
Merged

refactor: reader readability and typing cleanups#145
maxrjones merged 2 commits into
developmentseed:mainfrom
maxrjones:refactor/cleanups

Conversation

@maxrjones

Copy link
Copy Markdown
Member

Summary

This PR applies some minor cleanup to the reader module. Primarily, the try...except blocks might imply to a developer that these are optional dependencies, when in fact they are required by the library, and removing unnecessary nesting for readability.

Testing

I ran the test suite locally.

PR checks

  • Standard CI runs automatically on each push.
  • To run the CDK synth check, add the run-cdk-checks label to this PR.
  • If you push more commits after that run completes, remove and re-add the label to run it again.
  • To trigger a dev deployment, add the deploy-dev label. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@hrodmn hrodmn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxrjones, looks good

@maxrjones
maxrjones enabled auto-merge (squash) August 18, 2026 15:49
@maxrjones
maxrjones merged commit 93a1688 into developmentseed:main Aug 18, 2026
10 checks passed
@maxrjones
maxrjones deleted the refactor/cleanups branch August 18, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants