ci: make CDK checks anonymous so they run on fork PRs - #144
Merged
maxrjones merged 2 commits intoAug 18, 2026
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hrodmn
requested changes
Aug 18, 2026
hrodmn
left a comment
hrodmn
left a comment
Contributor
There was a problem hiding this comment.
This looks great but we should update it so that changes to the re-usable workflow file (.github/actions/cdk-deploy/action.yml) will trigger the synth test.
Comment on lines
+39
to
+41
| if echo "$files" | grep -q '^\.github/workflows/cdk-checks\.yml$'; then | ||
| # this workflow itself changed | ||
| echo "run=true" >> "$GITHUB_OUTPUT" |
Contributor
There was a problem hiding this comment.
we should also run the workflow if .github/actions/cdk-deploy/action.yml changes
hrodmn
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the CDK Checks workflow to run outside the
devenvironment, using dummy env variables, so that it can be safely tested on PRs coming from forks.Testing
No local testing, will try out the label that triggers the workflow.
PR checks
run-cdk-checkslabel to this PR.deploy-devlabel. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.