chore: require icechunk >=2.1 - #142
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hrodmn
left a comment
There was a problem hiding this comment.
@maxrjones thanks for opening the PR. To get the last CI check to pass you just need to add the run-cdk-checks label which will kick off the slow CDK build test.
The CDK tests don't pass because the env variables aren't available for workflows run from my fork. A few options solve this are:
Do you have a preference? |
|
ah, sorry for the turbulence on that. I'm ok with just merging this one but if there is a way to make that workflow approvable for PRs from forks then that would be a nice feature to add. |
that sounds good, I can work on that. I think it'd be good to have very minimally scoped role for this (just cdk synth, no actual deploy). Is it alright for me to set up those roles in the same AWS account for the updated workflow? |
|
The cdk-checks workflow uses an actual account id but we should be able to just do that with dummy values. let's plan on making that workflow completely anonymous and not pulling from our deployment env vars. |
Summary
This PR bumps the minimum Icechunk version to >=2.1. Icechunk 2.1 added support for attaching custom HTTP headers to object-store requests, which allows using titiler-multidim with EDL. This PR is a minimal dep bump which will setup later feature PRs for HTTP schemes.
Testing
I ran the test suite, and manually tested with a virtual Icechunk store pointing to NASA tempo data (using these changes + some that will fit in follow up PRs).
PR checks
run-cdk-checkslabel to this PR.deploy-devlabel. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.