Skip to content

chore: require icechunk >=2.1 - #142

Merged
maxrjones merged 2 commits into
developmentseed:mainfrom
maxrjones:chore/bump-icechunk-2.1
Aug 18, 2026
Merged

chore: require icechunk >=2.1#142
maxrjones merged 2 commits into
developmentseed:mainfrom
maxrjones:chore/bump-icechunk-2.1

Conversation

@maxrjones

Copy link
Copy Markdown
Member

Summary

This PR bumps the minimum Icechunk version to >=2.1. Icechunk 2.1 added support for attaching custom HTTP headers to object-store requests, which allows using titiler-multidim with EDL. This PR is a minimal dep bump which will setup later feature PRs for HTTP schemes.

Testing

I ran the test suite, and manually tested with a virtual Icechunk store pointing to NASA tempo data (using these changes + some that will fit in follow up PRs).

PR checks

  • Standard CI runs automatically on each push.
  • To run the CDK synth check, add the run-cdk-checks label to this PR.
  • If you push more commits after that run completes, remove and re-add the label to run it again.
  • To trigger a dev deployment, add the deploy-dev label. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@maxrjones
maxrjones requested a review from hrodmn August 17, 2026 18:42
@github-actions github-actions Bot added the chore label Aug 17, 2026

@hrodmn hrodmn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxrjones thanks for opening the PR. To get the last CI check to pass you just need to add the run-cdk-checks label which will kick off the slow CDK build test.

@maxrjones

Copy link
Copy Markdown
Member Author

@maxrjones thanks for opening the PR. To get the last CI check to pass you just need to add the run-cdk-checks label which will kick off the slow CDK build test.

The CDK tests don't pass because the env variables aren't available for workflows run from my fork. A few options solve this are:

  1. override the failure and merge
  2. re-open the PR from a branch inside the repo rather than my fork
  3. change the workflow to trigger on pull_request_target rather than pull_request, adding an approval requirement for workflows to run to reduce exposure risk.

Do you have a preference?

@hrodmn

hrodmn commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

ah, sorry for the turbulence on that. I'm ok with just merging this one but if there is a way to make that workflow approvable for PRs from forks then that would be a nice feature to add.

@maxrjones

Copy link
Copy Markdown
Member Author

ah, sorry for the turbulence on that. I'm ok with just merging this one but if there is a way to make that workflow approvable for PRs from forks then that would be a nice feature to add.

that sounds good, I can work on that. I think it'd be good to have very minimally scoped role for this (just cdk synth, no actual deploy). Is it alright for me to set up those roles in the same AWS account for the updated workflow?

@hrodmn

hrodmn commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The cdk-checks workflow uses an actual account id but we should be able to just do that with dummy values. let's plan on making that workflow completely anonymous and not pulling from our deployment env vars.

@maxrjones
maxrjones merged commit 32e2667 into developmentseed:main Aug 18, 2026
10 checks passed
@maxrjones
maxrjones deleted the chore/bump-icechunk-2.1 branch August 18, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants