-
Notifications
You must be signed in to change notification settings - Fork 9
feat: access key custom attributes CRU #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+ test related to descope/etc#13177
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/access_key.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for custom attributes in access key management operations (Create, Read/Search, and Update). The changes enable users to associate custom key-value attributes with access keys and filter by these attributes during search operations.
Changes:
- Added
custom_attributesparameter tocreate,search_all_access_keys, andupdatemethods in the AccessKey management class - Extended search functionality with
bound_user_idandcreating_userfilter parameters - Updated tests to validate the new parameters are correctly passed to the API
- Updated README documentation with examples showing the new parameters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| descope/management/access_key.py | Added custom_attributes parameter to create, search, and update methods; added bound_user_id and creating_user to search method |
| tests/management/test_access_key.py | Updated tests to validate new parameters are correctly serialized and sent to API endpoints |
| README.md | Updated code examples to demonstrate usage of custom_attributes and new search filters |
| .vscode/settings.json | Added workspace color customizations (unrelated to feature) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
related to https://github.com/descope/etc/issues/13177