Fix race condition in local_archive strategy on parallel deploys#4235
Open
rockschtar wants to merge 1 commit into
Open
Fix race condition in local_archive strategy on parallel deploys#4235rockschtar wants to merge 1 commit into
rockschtar wants to merge 1 commit into
Conversation
When deploying to multiple hosts in parallel, deploy:update_code runs once per host in its own worker, but all workers shared the same local archive file. The first host to finish unlinked it, so slower hosts failed with "No such file or directory"; a rebuild could also truncate an in-flight upload. Build the archive into a unique per-host file instead. Refs deployphp#4232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying to multiple hosts in parallel, deploy:update_code runs once per host in its own worker, but all workers shared the same local archive file. The first host to finish unlinked it, so slower hosts failed with "No such file or directory"; a rebuild could also truncate an in-flight upload. Build the archive into a unique per-host file instead.
Refs #4232
Bug fix local_archive strategy: race condition on shared archive.tar when deploying to multiple hosts in parallel #4232
New feature?
BC breaks?
Tests added?
Docs added?