-
Notifications
You must be signed in to change notification settings - Fork 0
feat: migrate build/release tooling to uv + python-semantic-release #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tomtranjr
wants to merge
1
commit into
main
Choose a base branch
from
feature/migrate-uv-semantic-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| name: Test and Release | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '*.md' | ||
| pull_request: | ||
| branches: [ main ] | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '*.md' | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| enable-cache: true | ||
|
|
||
| - name: Sync dependencies | ||
| run: uv sync | ||
|
|
||
| - name: Run tests | ||
| run: uv run pytest | ||
|
|
||
| release: | ||
| needs: test | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | ||
| runs-on: ubuntu-latest | ||
| concurrency: | ||
| group: release | ||
| cancel-in-progress: false | ||
| permissions: | ||
| contents: write # semantic-release pushes the version commit + tag + GitHub Release | ||
| id-token: write # OIDC trusted publishing to PyPI (no token needed) | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # semantic-release needs full history to analyse commits | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| enable-cache: true | ||
|
|
||
| - name: Sync dependencies | ||
| run: uv sync | ||
|
|
||
| - name: Python Semantic Release (bump, changelog, tag, build) | ||
| id: release | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| rm -rf dist | ||
| uv run semantic-release version | ||
| if ls dist/*.whl >/dev/null 2>&1; then | ||
| echo "released=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "released=false" >> "$GITHUB_OUTPUT" | ||
| echo "No release-worthy commits since the last tag; skipping publish." | ||
| fi | ||
|
|
||
| - name: Publish to PyPI (trusted publishing) | ||
| if: steps.release.outputs.released == 'true' | ||
| run: uv publish | ||
|
|
||
| - name: Attach artifacts to the GitHub Release | ||
| if: steps.release.outputs.released == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: uv run semantic-release publish | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| __pycache__ | ||
| poetry.lock | ||
| .DS_Store | ||
| .terraform | ||
| .terraform.lock.hcl | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| """Smoke tests: verify the package installs and its version resolves. | ||
|
|
||
| These are intentionally minimal and run against whatever source is on `main`. | ||
| The broader unit suite currently lives on the `dev` branch and targets modules | ||
| not yet merged to `main`; it should be wired in once those land here. | ||
| """ | ||
|
|
||
| import importlib.metadata | ||
|
|
||
|
|
||
| def test_distribution_is_installed(): | ||
| """The built/installed distribution exposes a version (packaging works).""" | ||
| assert importlib.metadata.version("deployml-core") | ||
|
|
||
|
|
||
| def test_cli_get_version_resolves(): | ||
| """The CLI resolves its version from package metadata, not the fallback.""" | ||
| from deployml.cli.cli import get_version | ||
|
|
||
| version = get_version() | ||
| assert isinstance(version, str) | ||
| assert version not in ("", "version unknown") | ||
| assert version == importlib.metadata.version("deployml-core") |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: both triggers here (
pushandpull_request) are scoped tobranches: [ main ]only. Is foldingdevin (e.g.branches: [main, dev]on thepull_requesttrigger) out of scope for this migration, or intentionally deferred? As-is, PRs intodevstill get zero CI from this workflow — same gap the oldtest-pypi.ymlhad.