Repository navigation
release 0.0.9907 - #145
release 0.0.9907#145
Conversation
avocet-bot
left a comment
There was a problem hiding this comment.
Review: #145 — "release 0.0.9907"
Reviewed head SHA: 037f011e45274a67acd8f94817823e63780b379f
Author: piscisaureus (Bert Belder) · Base: main · Head: release-0.0.9907
What this PR does (background for a reader new to the repo)
deploy-cli is the command-line tool / library published to JSR as the package
@deno/deploy. Its package manifest is deno.json, which carries both the
package's own published version and its dependency import map. Releases in this
repo are cut by a dedicated, minimal PR that only increments the version field;
the actual feature/dependency work lands in earlier, separately-reviewed PRs that
merge to main first.
This PR is exactly that kind of release cut. The entire diff is a single line:
- "version": "0.0.9906",
+ "version": "0.0.9907",The PR body notes the release "includes #144" — the bump of
@deno/framework-detect to 0.3.3 (which adds support for deploy.buildTimeout
expressed in seconds or with an s/m/h suffix). That dependency change is
already on main (merged via #144, which I reviewed earlier), so it does not
appear in this PR's diff; this PR only stamps the new version number onto the
release that will carry it.
Verification performed
-
Diff is exactly the self-version bump. Only the
versionfield of the
@deno/deploypackage changes, incrementing monotonically9906 → 9907,
consistent with the prior release cadence (#141 → 9905, #143 → 9906). -
The
@deno/framework-detect0.3.3 claim is consistent at head.
deno.jsonat this SHA pinsjsr:@deno/framework-detect@^0.3.3, and
deno.lockresolves it to0.3.3. Nothing about the dependency is left
dangling by this release. -
deno.lockdoes not need (and does not get) an update. A package's own
versionfield is never recorded in its own lockfile, so a self-version bump
correctly requires nodeno.lockchange. None is missing. -
The
^vs~appearance in the lock is NOT drift. Every caret-pinned
0.ximport indeno.json(framework-detect, sandbox, jsonc-morph, @std/tar,
dax) appears in the~form indeno.lock. For0.xversions^0.3.3and
~0.3.3denote the identical range (>=0.3.3 <0.4.0); Deno normalizes them in
the lockfile. This is uniform across all deps and is expected behavior. -
Publish risk is low. The JSR publish dry-run checks are green at head,
confirming0.0.9907is a valid, previously-unpublished, publishable version.
(Per prior experience on this repo,main'sdenoCI job can be
pre-existing-red on twocli_contracttests; a pure version-string change
cannot affect those, so any red there would be pre-existing and not
attributable to this PR — attribute by comparing pass/fail counts to base, not
the raw red.)
Findings
No blocking issues. No non-blocking findings. This is a clean, consistent
release-version bump with no correctness, regression, security, concurrency, or
edge-case concerns, and no missing lockfile update.
Recommendation
Approve.
Review skill evidence
- Invoked the
pr-review-toolkit:code-reviewersubagent (via the Task/Agent
tool) as the primary review pass. It independently fetched the diff,deno.json,
anddeno.lockat head and confirmed: the diff is the single version line, the
lockfile needs no update, framework-detect 0.3.3 is consistent, the^/~
form is a false alarm, and publish dry-runs are green. - Reviewer corroborated the subagent's findings against head-SHA blob reads
(deno.json,deno.lock) and the PR metadata.
Bumps the version in
deno.jsonto0.0.9907. Includes:@deno/framework-detect0.3.3: deno.jsondeploy.buildTimeoutin seconds or with an
s/m/hsuffix