Repository navigation
test(core): expect E44 on Windows when a refresh lands over 0.3.x - #131
Merged
Merged
Conversation
dg-coreylweathers
force-pushed
the
fix/win-legacy-refresh-warning
branch
4 times, most recently
from
October 9, 2026 13:52
3e845a0 to
9bad985
Compare
dg-coreylweathers
force-pushed
the
fix/win-legacy-refresh-warning
branch
5 times, most recently
from
October 9, 2026 14:16
13589cd to
be7a3ac
Compare
#126 asserted that landing new skill folders over a record written by deepctl 0.3.x prints nothing. #130 made Windows skip the 0.3.x cleanup and print E44 once. Each passed on its own branch; together on main every Windows job fails. The test now has three named cases: native, forced-windows (the Windows branch on POSIX, skipped on Windows where native already is), and removed. The Windows branch expects one E44 for the recorded path, the POSIX branch silence, and both assert that the 0.3.x path leaves the record, the v03 flag is cleared, and a second refresh prints nothing (on Windows a stale path would print E44 again). Both sides of the E44 match normalize whitespace so a console wrap cannot split them. The comment names deepctl as the actor: the cleanup runs after any tool's folders land, from dg skills, dg login and dg plugin.
dg-coreylweathers
force-pushed
the
fix/win-legacy-refresh-warning
branch
from
October 9, 2026 14:23
be7a3ac to
e5cac81
Compare
GregHolmes
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main's test workflow fails on every Windows job since #126 and #130 met on main (test run 37930234857). One test,
TestRecheckUnderLock::test_03x_only_tool_still_gets_folders_on_refresh[False].Each PR was green on its own branch. #126 branched from 63c2be1, before #130 added E44.
Change
Test only, one commit. The test now has three named cases:
native: the branch the host OS takes.forced-windows: the Windows branch on POSIX, by settingskill_generator._WINDOWSthe way other tests in the file do. Skipped on Windows, wherenativealready covers it. The POSIX branch is never forced on Windows.removed: the tool is removed during the download, unchanged from fix(skills): keep a newer skills ref and a removed tool when a refresh overlaps #126.The Windows branch expects exactly one E44 naming the recorded path, with whitespace normalized on both sides so a console wrap cannot split the match. The POSIX branch expects empty stderr. Both then assert that the 0.3.x path left the record, only the two new skill folders remain listed, the
v03flag is cleared, and a second refresh prints nothing. On Windows a stale path would print E44 again, so that last check is load-bearing there.Checked, on head e5cac81 (tree identical to be7a3ac, where the gate ran)
pytest -k TestRecheckUnderLockon macOS: 12 passed, includingforced-windows.nativeandforced-windowsfail on the paths assertion; with thev03flag left in place they fail on the flag assertion.ruff format --checkon this test file reports blocks around lines 2312 and 2324 that are already unformatted on main and are not touched here. CI runsruff format --checkandruff checkonsrc/andpackages/*/srconly, so test files are not formatted or linted in CI.This is a
test:commit, so release-please adds no changelog line.🤖 Generated with Claude Code