fix: toggle settings feature alignment

[lorenzo-ranciaffi]

Pull Request Description

Fixes #8424

What does this PR change?

This PR re-aligns all the toggle feature values to the proper configuration (every toggle was shifted by 1 by the improperly ordering of CHAT_REACTIONS_ENABLED_FEATURE on its creation).

Now all features (toggle, slider and dropdown) have a fixed index enum value so that every new addition can't affect the previous ones.

Test Steps

1. Verify the steps in the linked issue
2. Verify that all possible settings (especially toggles) modify the proper feature (e.g. v-sync toggle modify the v-sync behaviour, Sun Lens Flare enables/disables the sun lens flare and so on...)

Quality Checklist

• Changes have been tested locally
• Documentation has been updated (if required)
• Performance impact has been considered
• For SDK features: Test scene is included

Code Review Reference

Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.

[github-actions]

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name	Link
Commit	97b9020
Logs	https://github.com/decentraland/unity-explorer/actions/runs/24998978879
Download Windows	https://github.com/decentraland/unity-explorer/suites/66359884138/artifacts/6662983965
Download Windows S3	https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/8424-toggle-settings-feature-alignment/pr-21518-97b9020/Decentraland_windows64.zip
Download Mac	https://github.com/decentraland/unity-explorer/suites/66359884138/artifacts/6663004081
Download Mac S3	https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/8424-toggle-settings-feature-alignment/pr-21518-97b9020/Decentraland_macos.zip
Built on	2026-04-27T14:27:40Z

[claude]

Claude finished @lorenzo-ranciaffi's task in 1m 52s —— View job

---

Code Review

• Gather context and read project docs
• Review changed files
• Analyze correctness of index assignments
• Check for blocking issues
• Post final review

---

Root-Cause Assessment

Problem: CHAT_REACTIONS_ENABLED_FEATURE was inserted into ToggleFeatures without an explicit integer value, silently shifting all subsequent enum members by +1. Because C# enums are persisted as their underlying integer in Unity .asset files, every toggle after that entry was wired to the wrong feature controller at runtime.

This PR fixes the root cause — not a symptom. Adding explicit integer literals to all three enums (ToggleFeatures, SliderFeatures, DropdownFeatures) and realigning the corresponding values in SettingsMenuConfiguration.asset directly prevents the class of bug where inserting a new member reorders existing mappings.

---

Correctness Verification

I cross-referenced every <Feature>k__BackingField: value in the asset against the updated enum definitions across all three binding types. All 35 entries are correctly aligned:

Binding type	Entries checked	All correct?
ToggleModuleBinding	12	✓
SliderModuleBinding	12	✓
DropdownModuleBinding	11	✓

Selected spot-checks:

• VSync (rid: ...747108) → Feature: 1 = GRAPHICS_VSYNC_TOGGLE_FEATURE = 1 ✓
• Sun Lens Flare (rid: ...013200) → Feature: 13 = SUN_LENS_FLARE_FEATURE = 13 ✓ (was 11 before, the misalignment described in the issue)
• Fullscreen (rid: ...260124) → Feature: 11 = FULLSCREEN_FEATURE = 11 ✓ (was 10 before)
• Play Current Scene Streams Only (rid: ...600993) → Feature: 12 = PLAY_CURRENT_SCENE_STREAM_ONLY_FEATURE = 12 ✓ (was 11 before)

---

No Blocking Issues Found

The protective comment added above each enum is appropriate and correctly documents the invariant future contributors must respect.

---

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Pure enum value anchoring and Unity asset data correction — no ECS systems, async patterns, or runtime logic modified.
QA_REQUIRED: YES

[github-actions]

Auto-approved by Claude — simple fix/chore with no blocking issues. QA approval is still required.

[balducciv]

QA Pass ✅

Tested on v0.142.0-alpha-fix/8424-toggle-settings-feature-alignment-97b9020 on macOS (M3 Pro) and Windows.

Verified:

• Original issue steps no longer reproduce
• All toggles affect only their own named feature (V-Sync, Sun Lens Flare, See others' reactions, etc.)
• Sliders and dropdowns correctly modify their respective settings
• Settings persist correctly after relaunch with proper values

No regressions found. Logs are clean of any errors related to this fix.

Evidence

Mac

27.04.2026_12.38.52_REC.PR-8484.mac.mp4

Player.log

Windows

Player windows 8484.log

27.04.2026_12.43.33_REC.mp4