fix(ci): modernize MS GPG key handling, migrate to bookworm base#773
Merged
Conversation
- Replace deprecated apt-key with gpg --dearmor + signed-by keyring approach - Scope keys per-repo (/usr/share/keyrings/microsoft-prod.gpg) - Add SHELL pipefail for robust error handling - Fix FROM casing (as -> AS) to eliminate Docker warnings - Switch base image from bullseye to bookworm for Python 3.14 compat Verified: base, msodbc17, msodbc18 all build clean; Python 3.11-3.14 range confirmed. Closes #435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rebased and validated version of #435. Two changes:
apt-keywithgpg --dearmor+signed-bykeyring — scopes keys per-repo, follows Microsoft's current recommended approach for Debianpython:3.14-bullseyedoesn't exist (404); bookworm covers the full 3.11–3.14 rangeVerified
basepython:3.11-bookwormmsodbc17msodbcsql17 17.11.1.1-1msodbc18msodbcsql18 18.6.2.1-1base(3.14)python:3.14-bookwormZero Docker warnings. Key URLs (
packages.microsoft.com/keys/microsoft.asc,/config/debian/{11,12}/prod.list, Azure CLI repo) all confirmed valid as of 2026-07-27.Microsoft approach confirmed
Same key (
microsoft.asc) serves ODBC + Azure CLI. Key path/usr/share/keyrings/microsoft-prod.gpgmatches Debian 12+ conventions and the existing devcontainer script. All URLs match Microsoft's official April 2026 docs.Closes #424