Cancellation semantics + signal map recfactoring#430
Open
devhawk wants to merge 10 commits into
Open
Conversation
kraftp
reviewed
Jun 11, 2026
kraftp
reviewed
Jun 11, 2026
kraftp
reviewed
Jun 12, 2026
|
|
||
| // Blocks until the workflow task actually exits, proving the recv loop detected the | ||
| // cancellation and the workflow thread terminated — not just that the DB was updated. | ||
| assertThrows(DBOSAwaitedWorkflowCancelledException.class, handle::getResult); |
Member
There was a problem hiding this comment.
This should also assert the workflow completes (getResult on the original handle) in reasonable time.
kraftp
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cancellation checks in recv and getEvent .
Alligned cancelation semantics to TS/Python. WorkflowCancelled is thrown inside the running workflow to abort it. AwaitedWorkflowCancelled is thrown to external callers requesting a result.
Simplied SignalMap, removed generic argument in favor of String and removed WakeReason.
fixes #414