fork from failure#425
Merged
Merged
Conversation
kraftp
approved these changes
Jun 9, 2026
kraftp
left a comment
kraftp
left a comment
Member
There was a problem hiding this comment.
Looks good--does this pass Conductor tests?
kraftp
reviewed
Jun 9, 2026
Collaborator
Author
|
(closed by accident, reopened) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements forkFromFailure, which re-executes a failed workflow starting from a specific prior step, copying completed step outputs so they don't re-run.
forkWorkflow and forkFromFailure now share a bulkForkWorkflows helper which owns transaction management and handles batch inserts
ForkOptions timeout field changed from Timeout to @nullable Duration — fork timeouts are always explicit or absent, never inherited. ForkOptions.timeout is a public field used by the API so this is a minor breaking change
fixes #351