Open
Conversation
I am proposing this change after some attempts working with the parallel queue in the Torino Cloud inftastructure. Nodes that require MPI and run on several virtual machines were not correctly treated by the previous code.
Owner
|
Hello @steog88, thanks for your contribution. I kindly ask you to address a number of points before merging this PR.
I like the From what I see this should work both for the "whole machine" case and the non-whole machine one. Did you test it to make sure it's the case? (This morning I woke up in |
Hi, thanks for the suggestions. I hope to have addressed all the requirements. Yes, I tested it with and without the "WholeMachine" case and it works.
Author
|
Hi, thanks for the suggestions. Yes, I tested it with and without the "WholeMachine" case and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am proposing this change after some attempts working with the parallel queue in the Torino Cloud inftastructure. Nodes that require MPI and run on several virtual machines were not correctly treated by the previous code.