Add a quiet zone for dark backgrounds#225
Open
marcdurham wants to merge 1 commit intodavidshimjs:masterfrom
Open
Add a quiet zone for dark backgrounds#225marcdurham wants to merge 1 commit intodavidshimjs:masterfrom
marcdurham wants to merge 1 commit intodavidshimjs:masterfrom
Conversation
If the QR Code is on a dark background it can't be read by some readers.
|
Great addition! I would love if this could be merged! Related to this convo that popped up after the PR #232 |
Author
Thanks @chrisblakley . I don't see any commits or completed pull requests to this repo newer than 7 years. I think @davidshimjs has moved on with his life, as one does. Maybe somebody new should pick it up and do a fork. I'd volunteer myself, but I barely know JavaScript. |
|
After I made that comment, I saw the commit history haha. I just used your fork locally instead of my CDN and that did the trick– thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the QR Code is on a dark background it can't be read by some readers.