-
Notifications
You must be signed in to change notification settings - Fork 146
Relax the threshold of a flaky test #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the threshold of a flaky test #598
Conversation
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
|
I run 10k instances with this threashold on my machine and it seemed to have done the job. However, PRs are still failing because of this test: |
|
The functionality that this test is evaluating is not working correctly and is tagged as experimental. The test remains flaky and the level of relaxation needed to get rid of the flakiness is starting to get unacceptable. Marking the test as |
tlwillke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to ignore the test for now. We will decide what to do with the related contribution. We can then revisit the recall threshold or permanently remove the test and related work.
Relax the threshold of OnHeapGraphIndexTest.testIncrementalInsertionFromOnDiskIndex_withIdentityOrdinalMapping as it was flaky