Skip to content

Conversation

@michaeljmarshall
Copy link
Member

Fixes: #586

Now that we lazily load the inMemoryNeighbors and the inMemoryFeatures, we need to handle the case where they are null or have values that are null. The added test fails without the change.

@michaeljmarshall
Copy link
Member Author

Supercedes #587

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Copy link
Contributor

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaeljmarshall added a commit to datastax/cassandra that referenced this pull request Dec 4, 2025
built from the branch in this
PR: datastax/jvector#588
Copy link
Contributor

@MarkWolters MarkWolters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Jonathan Shook <jshook1@ibm.com>
Copy link
Collaborator

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tlwillke tlwillke merged commit a66fd91 into main Jan 26, 2026
13 of 20 checks passed
@tlwillke tlwillke deleted the npe-rambytesused branch January 26, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE when calling OnDiskGraphIndex#ramBytesUsed

6 participants