-
Notifications
You must be signed in to change notification settings - Fork 146
Fix OnDiskGraphIndex#ramBytesUsed NPE #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Supercedes #587 |
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
marianotepper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
built from the branch in this PR: datastax/jvector#588
MarkWolters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jonathan Shook <jshook1@ibm.com>
tlwillke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixes: #586
Now that we lazily load the
inMemoryNeighborsand theinMemoryFeatures, we need to handle the case where they arenullor have values that arenull. The added test fails without the change.