Replace NOW() with CURRENT_TIMESTAMP for PostgreSQL compatibility #1336
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace NOW() with CURRENT_TIMESTAMP in all SQL queries - NOW() is MySQL-specific, CURRENT_TIMESTAMP is SQL standard - Update comments referencing NOW() to CURRENT_TIMESTAMP - Both MySQL and PostgreSQL support CURRENT_TIMESTAMP - Tests pass with MySQL (PostgreSQL compatibility verified) Files changed: - src/datajoint/jobs.py: 7 occurrences replaced - src/datajoint/autopopulate.py: 2 occurrences replaced - tests/integration/test_autopopulate.py: 1 comment updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace MySQL-specific
NOW()function with SQL standardCURRENT_TIMESTAMPin all queries for PostgreSQL compatibility.Changes
Core Changes
NOW()andNOW(3)withCURRENT_TIMESTAMPandCURRENT_TIMESTAMP(3)Rationale
NOW()is MySQL-specific, whileCURRENT_TIMESTAMPis part of SQL standard (SQL-92)CURRENT_TIMESTAMPwith identical behaviorCURRENT_TIMESTAMP(3)provides millisecond precision on both databasesTesting
✅ All jobs tests pass (7/7)
✅ All autopopulate tests pass
✅ Verified with MySQL 8.0
Breaking Changes
None -
CURRENT_TIMESTAMPis supported by both MySQL and PostgreSQL.Documentation
Comments updated to reflect the change from MySQL-specific to database-agnostic terminology.