-
Notifications
You must be signed in to change notification settings - Fork 228
Add new device models to device.yml #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1750 +/- ##
============================================
- Coverage 92.35% 92.33% -0.02%
Complexity 3440 3440
============================================
Files 338 338
Lines 6785 6785
Branches 670 670
============================================
- Hits 6266 6265 -1
- Misses 354 355 +1
Partials 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is no Plus model in the 17 line-up, but Apple did add the Air. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request expands the device.yml file with many recent smartphone models from major manufacturers to improve device coverage for testing or feature functionality that depends on this list.
Changes:
- Added iPhone 15 and 16 series models (Plus, Pro, Pro Max variants)
- Added OnePlus 7-12 series devices including Pro and T variants
- Added Samsung Galaxy S10-S24 series with Plus, Ultra, and e variants
- Added Google Pixel 7a through 9 Pro XL models
- Added Xiaomi Mi 9-14 and Redmi Note 7-12 devices
- Included unreleased devices: iPhone 17 series and iPhone Air
|
Apparently that was beyond copilot's knowledge window. For the record the Apple iPhone 17 series were released Sept 2025. |
|
I'm going to let someone else merge this. Since I ended up contributing to it someone else should also review it. |
src/main/resources/en/device.yml
Outdated
| - "Samsung Galaxy S24" | ||
| - "Samsung Galaxy S24 Plus" | ||
| - "Samsung Galaxy S24 Ultra" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already S25
https://www.samsung.com/smartphones/all-smartphones/
|
Thanks @snuyanzin I'll tackle that |
|
I've added the devices pointed at the review comments. |
This pull request updates the
device.ymlfile to expand the list of supported devices with many recent models from major smartphone brands. The additions ensure broader and more up-to-date device coverage, which is important for features or tests that rely on this device list.Device list updates: