SVG generation updates#597
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the statistical variable group generation logic in stat_var_group_generator.py to support observationProperties (specifically measuredProperty) when matching and generating SVGs, and updates the end-to-end tests to verify these changes. The review feedback highlights two critical issues in the BigQuery SQL queries: a potential runtime error when unnesting a NULL observationProperties array, and a logic bug where equality comparisons with NULL prevent zero-constraint SVs from matching vertical specs that do not define observation properties.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Based on reviewing in dev, made a few tweaks to hierarchy generation
Latest iteration is currently on dev