Added pre-upgrade check for defect CSCwt69100#385
Conversation
Priyanka-Patil14
force-pushed
the
CSCwt69100-fix-clean
branch
from
5ba0fb4 to
a66b043
Compare
Harinadh-Saladi
left a comment
Harinadh-Saladi
left a comment
There was a problem hiding this comment.
I could see you have added only full script run logs. Can you attach your function alone logs. Please add the logs for PASS,FAIL and NA scenarios.
As Lovkesh has confirmed that attaching FAIL logs is not required (Issue is not recreatable, since repro factor is very less), pls attach cu log as a fail evidence.
Harinadh-Saladi
left a comment
Harinadh-Saladi
left a comment
There was a problem hiding this comment.
Address the comments
|
Pls add pytest logs for your check as you added additional test cases. |
Attached the pytest logs for the check. |
Priyanka-Patil14
force-pushed
the
CSCwt69100-fix-clean
branch
from
c7b7ff9 to
d64dcc6
Compare
lovkeshsharma702
left a comment
lovkeshsharma702
left a comment
There was a problem hiding this comment.
Requirement already satisfied: MarkupSafe>=0.23 in ./venv27/lib/python2.7/site-packages (from jinja2==2.11.3->-r tests/requirements-py27.txt (line 7)) (1.1.1)
$ pytest --junitxml=report.xml
============================= test session starts ==============================
platform linux2 -- Python 2.7.11, pytest-4.6.11, py-1.11.0, pluggy-0.13.1
rootdir: /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script, inifile: pytest.ini
collected 875 items / 1 errors / 874 selected
==================================== ERRORS ====================================
_ ERROR collecting tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py _
venv27/lib/python2.7/site-packages/_pytest/python.py:507: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
venv27/lib/python2.7/site-packages/py/_path/local.py:704: in pyimport
import(modname)
E File "/builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py", line 62
E SyntaxError: Non-ASCII character '\xe2' in file /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py on line 62, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
- generated xml file: /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/report.xml -
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 10.94 seconds ===========================
Uploading artifacts for failed job
00:03
Uploading artifacts...
report.xml: found 1 matching artifact files and directories
Uploading artifacts as "junit" to coordinator... 201 Created id=440 responseStatus=201 Created token=glcbt-64
ERROR: Job failed: exit code 1
|
|
||
| Due to [CSCwt69100][70], a stale `dbgacEpgSummaryTask` object stuck in `processing` state with empty content can cause the policymgr process to crash on all APICs during an upgrade or process restart. | ||
|
|
||
| Contact Cisco TAC to delete the offending `dbgacEpgSummaryTask` objects before the upgrade. For more details, refer to the workaround in [CSCwt69100][70]. |
There was a problem hiding this comment.
this needs to be udpated with true next steps, "Contact TAC for next steps"
| result = PASS | ||
| headers = ["DN", "Start Time"] | ||
| data = [] | ||
| recommended_action = "Contact Cisco TAC to delete the offending dbgacEpgSummaryTask objects before the upgrade. For more details, refer to the workaround in [CSCwt69100](https://bst.cloudapps.cisco.com/bugsearch/bug/CSCwt69100)." |
There was a problem hiding this comment.
fix this recomended action, "Contact Cisco TAC"
| if not tversion: | ||
| return Result(result=MANUAL, msg=TVER_MISSING) |
There was a problem hiding this comment.
does fix stop the crash?
And if we want to be able to flag and do research on this anyways, we could perform check regardless of tversion just to see if the object exists.
TBD.
4 participants
Summary:
-This PR adds a new validation check: Stale dbgacEpgSummaryTask Objects.
-The check detects stale
dbgacEpgSummaryTaskobjects stuck inprocessingstate that can cause policymgr to crash on all APICs during upgrade (CSCwt69100).What Changed:
stale_epg_summary_task_checkinaci-preupgrade-validation-script.pydocs/docs/validations.mdtests/checks/stale_epg_summary_task_check/Check Behavior:
N/Aif target version is not in affected range (<= 6.1(5e) or <= 6.2(1g))PASSif nodbgacEpgSummaryTaskobjects found inprocessingstatePASSif objects found butstartTsis within 24 hoursFAIL_Oif anydbgacEpgSummaryTaskobject hasstartTsolder than 24 hoursTest Results:
Pytest Logs: Full Run:
CSCwt69100_Pytest_FullRun_Logs.txt
Pytest Logs: stale_epg_summary_task_check (8 test cases)
CSCwt69100_pytest.txt
Full run (tversion 6.1(5e) and 6.2(2a)):
CSCwt69100_FullRun_logs.txt
Script Run Logs (PASS / NA / FAIL):
CSCwt69100_PASS:FAIL:NA_logs.txt
Note: Added FAIL log from CU as lab repro is not feasible.