fix(connectors): show BigQuery in Add Connection dropdown - #701
Open
larsgeorge-db wants to merge 1 commit into
Open
fix(connectors): show BigQuery in Add Connection dropdown#701larsgeorge-db wants to merge 1 commit into
larsgeorge-db wants to merge 1 commit into
Conversation
The connector type dropdown was gated on each connector's runtime is_available property. BigQuery's is_available does a live client check that fails until a project/credentials are configured, which is always true at startup, so the fully-implemented BigQuery connector was filtered out of the dialog that is meant to configure it. Introduce a static is_selectable class flag (implementation status, distinct from runtime availability) and gate list_connector_types() on it. Stub connectors (Snowflake, PowerBI, Kafka) set is_selectable=False and stay hidden. Adds regression tests. Follow-up for a dedicated external Unity Catalog connector (OAuth M2M): #683
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Add Connection" dropdown was missing the fully-implemented BigQuery connector.
Root cause:
ConnectionsManager.list_connector_types()gated the dropdown on each connector's runtimeis_availableproperty. BigQuery'sis_availableperforms a live client check that fails until a project/credentials are configured — which is always the case at startup — so BigQuery was filtered out of the very dialog meant to configure it.Fix: introduce a static
is_selectableclass flag (implementation status, distinct from runtime availability) and gate the dropdown on that instead. Stub/mockup connectors (Snowflake, PowerBI, Kafka) setis_selectable = Falseand stay hidden.Changes
connectors/base.py— addis_selectable: bool = TrueonAssetConnector, documented vs. runtimeis_available.connectors/{snowflake,powerbi,kafka}.py—is_selectable = False(stubs stay hidden).controller/connections_manager.py— filter onis_selectableinstead ofis_available; updated docstring.tests/test_connections_manager_connector_types.py— regression tests (BigQuery listed despiteis_available=False, default databricks always listed, stubs hidden, metadata populated).Notes
CONNECTOR_CONFIG_FIELDS, and the existing!== 'databricks'filter correctly keeps the system Unity Catalog connection out of the create flow.Testing
pytest tests/test_connections_manager_connector_types.py— 4 passed. Verified against the real registry thatbigquerynow surfaces while the three stubs remain hidden.Closes #683 is not intended — that is tracked as a separate follow-up.