Correct unspecified enum constant values#270
Draft
tejaskochar-db wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects generated unspecified enum constants so their runtime value is the empty string instead of the proto symbolic name. This is a breaking correction to the beta API surface.
Why
Unspecified enum members represent absence. Exposing their symbolic names as runtime values made them look like sendable wire values, even though callers should omit the field instead. Using
""aligns the constants with absence and prevents the SDK from presenting a sentinel as an explicit value to send.What changed
Interface changes
*_UNSPECIFIEDconstants now equal""instead of their symbolic names.Behavioral changes
Internal changes
How is this tested?
npm run cipasses, including builds, linting, formatting checks, type checking, Node tests, browser tests, and license validation.