Make ssh setup work with interactive cluster selection#5207
Open
Make ssh setup work with interactive cluster selection#5207
Conversation
anton-107
approved these changes
May 7, 2026
Contributor
anton-107
left a comment
anton-107
left a comment
There was a problem hiding this comment.
Fix is correct and well-scoped — moving ToProxyCommand() after the cluster picker resolves the empty --cluster= flag bug.
One nit: TestSetup_PromptsForClusterWhenNotProvided reads as "verifies the picker runs," but the load-bearing assertion is that the picked ID flows into the proxy command. Something like TestSetup_PickedClusterFlowsIntoProxyCommand describes the regression more precisely. Non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the creation of
proxyCommandto after interactive cluster selectionWhy
Before
proxyCommandwas created before interactive cluster selection, meaning we would output a broken proxy command in the generate SSH config. Moving creation ofproxyCommandto after interactive cluster selection means the selected cluster is properly populated in the generated SSH configTests
Added test