Add WAL for direct deployment state recovery #4106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
2 times, most recently
from
b51a199 to
7f67cb2
Compare
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
from
7f67cb2 to
baf371e
Compare
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
from
86b90ce to
98a1893
Compare
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
from
98a1893 to
5cb5da4
Compare
Contributor
Author
|
@denik @andrewnester the pr is ready for review |
Contributor
Author
|
@denik @andrewnester bumping again ^^ |
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
from
5cb5da4 to
0e7c9fa
Compare
Contributor
Author
|
@denik fixed the build failures, could you approve the workflows |
Signed-off-by: Varun Deep Saini <[email protected]>
Signed-off-by: Varun Deep Saini <[email protected]>
Signed-off-by: Varun Deep Saini <[email protected]>
varundeepsaini
force-pushed
the
feature/deploy-append-log
branch
from
1b3af30 to
34e0f37
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
@denik could you approve the workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4090
Changes
Add write-ahead log (WAL) to record state changes during direct deployment, enabling recovery of partial state if deployment is interrupted.
Added an Offset To KillCaller. Now it starts killing the process after Offset Successful requests to the endpoint
Why
Today, if deployment is interrupted before
Finalize(), no state is saved, and created resources become orphaned. The WAL writes each state change immediately to disk and replays them on restart.Tests
Tests added for WAL save/replay, delete/replay, finalize cleanup, and edge cases.