Repository navigation
feat(login): log in with Dash0's first-party OAuth client on Dash0-hosted API URLs - #304
Draft
securitymirco wants to merge 1 commit into
Draft
securitymirco wants to merge 1 commit into
securitymirco wants to merge 1 commit into
Conversation
…sted API URLs Co-Authored-By: Claude <noreply@anthropic.com>
securitymirco
force-pushed
the
feat/first-party-oauth-client
branch
from
October 6, 2026 10:38
3c75c6e to
56b90e5
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dash0 loginregisters its own OAuth client (RFC 7591 dynamic client registration) on first login. The authorization server cannot distinguish that client from any other client using the same name, so the consent screen cannot present the CLI as an official Dash0 application.With this change, logins against Dash0-hosted API URLs use a fixed, pre-provisioned client ID (
dash0-cli). Logins against any other API URL, such as a local stack or a custom deployment, keep using dynamic registration and the~/.dash0/oauth-clients.jsoncache.deriveAppHost, the strict matcher already used for the post-login redirect (api.dash0.com,api.<region>.aws.dash0.com, and thedash0-dev.comequivalents).logoutkeep working. The nextdash0 loginmoves them to the new client and revokes the previous refresh token under its original client ID, as re-login already does.docs/commands.mdand the matching skill reference are updated, and a changelog entry is included.Testing
TestEnsureRegisteredClient_Dash0HostedUsesFirstPartyClient: Dash0-hosted URLs resolve to the fixed client without calling the registration endpoint.🤖 Generated with Claude Code