Obfuscate the test runner connection for VM and Node tests#2704
Open
natebosch wants to merge 3 commits into
Open
Obfuscate the test runner connection for VM and Node tests#2704natebosch wants to merge 3 commits into
natebosch wants to merge 3 commits into
Conversation
Unix domain sockets (using a file in a freshly created temp directory) are more secure by default than server sockets. Since Dart 3.11.0 (and windows 10) we have the ability to use unix domain sockets on windows, so use them everywhere now.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
No support for unix domain sockets in node on windows
natebosch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix domain sockets (using a file in a freshly created temp directory)
are more secure by default than server sockets. Since Dart 3.11.0 (and
windows 10) we have the ability to use unix domain sockets on windows,
so use them for VM tests now.
Node on windows still does not support unix domain sockets, so add a
secret token shared in a freshly created temp directory.