Skip to content

Conversation

@mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Dec 13, 2025

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1603

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mcruzdev mcruzdev requested review from a team as code owners December 13, 2025 21:51
@artur-ciocanu
Copy link
Contributor

artur-ciocanu commented Dec 15, 2025

@mcruzdev I am wondering why we need to increase to such a high number. Also could you please sign your commit

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artur-ciocanu
Copy link
Contributor

@mcruzdev I still see issues like these:

 Error:  Errors: 
Error:    DaprPubSubOutboxIT.shouldPublishUsingOutbox:126 » ConditionTimeout Assertion condition defined as a Lambda expression in io.dapr.it.testcontainers.pubsub.outbox.DaprPubSubOutboxIT 
Expecting actual not to be empty within 45 seconds.

@cicoyle
Copy link
Contributor

cicoyle commented Dec 17, 2025

+1 I think this needs a bit more investigation here beyond upping the time since it still fails. Appreciate the efforts here 🎉

@mcruzdev mcruzdev changed the title Increase atMost condition to at most 45 seconds Solve FlakyTest: DaprPubSubOutboxIT Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.90%. Comparing base (d759c53) to head (b729f67).
⚠️ Report is 249 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1605      +/-   ##
============================================
+ Coverage     76.91%   78.90%   +1.98%     
- Complexity     1592     2074     +482     
============================================
  Files           145      227      +82     
  Lines          4843     6256    +1413     
  Branches        562      684     +122     
============================================
+ Hits           3725     4936    +1211     
- Misses          821      972     +151     
- Partials        297      348      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky tests on PubSubOutbox pattern

4 participants