DAOS-18681 object: Fix potential memory leaks and error handling#17730
Open
wangshilong wants to merge 3 commits intomasterfrom
Open
DAOS-18681 object: Fix potential memory leaks and error handling#17730wangshilong wants to merge 3 commits intomasterfrom
wangshilong wants to merge 3 commits intomasterfrom
Conversation
This patch fixes several resource-handling bugs that could lead to memory leaks or crashes(all catched by AI): 1.Avoid leaking memory allocated in tse_task_cb() when tse_task_reinit_with_delay() fails by introducing a helper to clean up on failure. 2. Ensure sub_anchors_free() is called on error paths for enumeration and key2anchor case. 3. Invoke dc_tx_local_close() on error paths to properly close local transactions. 4. Make drpc_call() return an error when allocation fails to avoid potential NULL dereference and segfault. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
|
Ticket title is 'Fix potential memory Leaks ' |
Nasf-Fan
previously approved these changes
Mar 18, 2026
NiuYawei
previously approved these changes
Mar 19, 2026
| if (comp_cb && !rc) | ||
| rc = register_cb(task, true, comp_cb, comp_data, | ||
| comp_data_size); | ||
| rc = register_cb(task, true, comp_cb, comp_data, comp_data_size, NULL); |
Contributor
There was a problem hiding this comment.
Minor: Looks this function could be used to register two callbacks, shouldn't we free the first one when the second registration failed?
Contributor
Author
There was a problem hiding this comment.
Indeed, this should be fixed as well.
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
Collaborator
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17730/1/display/redirect |
Nasf-Fan
approved these changes
Mar 19, 2026
liuxuezhao
approved these changes
Mar 19, 2026
NiuYawei
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes several resource-handling bugs that could lead to memory leaks or crashes(all catched by AI):
1.Avoid leaking memory allocated in tse_task_cb() when tse_task_reinit_with_delay() fails by introducing a helper to clean up on failure.
2. Ensure sub_anchors_free() is called on error paths for enumeration and key2anchor case.
3. Invoke dc_tx_local_close() on error paths to properly close local transactions.
4. Make drpc_call() return an error when allocation fails to avoid potential NULL dereference and segfault.
Steps for the author:
After all prior steps are complete: