DAOS-17688 ddb: Disables C code write to stdout buffering (#17701)#17728
Draft
knard38 wants to merge 1 commit intorelease/2.6from
Draft
DAOS-17688 ddb: Disables C code write to stdout buffering (#17701)#17728knard38 wants to merge 1 commit intorelease/2.6from
knard38 wants to merge 1 commit intorelease/2.6from
Conversation
When a Go program's stdout is connected to a pipe (e.g. redirected or piped to another process), C stdout becomes fully-buffered by Unix convention instead of line-buffered, which can cause output from C functions such as printf() to be lost or delayed. Disabling buffering ensures that C stdout output is flushed immediately, consistent with the behavior of Go's own stdout. Features: recovery Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
|
Ticket title is 'Not possible to use ddb stdout with pipe' |
github-actions
bot
added
the
priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unclean cherry pick of the PR #17701 :
src/control/logging/cstdio.goDisableCStdoutBuffering()in ddb.main.When a Go program's stdout is connected to a pipe (e.g. redirected or piped to another process), C stdout becomes fully-buffered by Unix convention instead of line-buffered, which can cause output from C functions such as printf() to be lost or delayed.
Disabling buffering ensures that C stdout output is flushed immediately, consistent with the behavior of Go's own stdout.
Steps for the author:
After all prior steps are complete: