Open
Conversation
andreufont
reviewed
Apr 10, 2026
Contributor
andreufont
left a comment
andreufont
left a comment
There was a problem hiding this comment.
I don't know enough about the code to validate the changes, but I'm sure you got it right.
@Laura-Casas - could you try running a new box with this branch, before merging?
We can then ask @dljarque to validate the new box.
|
Here is the validation for CMB lensing of two CoLoRe boxes run by @Laura-Casas. One prior to the source plane z_s change, and the second one with the new implementation of this pull request. They both seem ok, thanks! Theory lines are computed with the linear PK from CAMB (matching CoLoRe cosmology) and manually integrating the Limber approximation up to z_cut. 
|
Owner
Author
|
Thanks @dljarque ! Any reason why you had to set zs=1090 in one case and 1100 in the other? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for lensing (and ISW) source planes to lie outside of the box. Line-of-sight integrals will only contain information up to z=z_max (passed in the param file), but the radial kernel will be that of a source plane at the requested distance.
Closes #75