[#2497, #2642, #2643, #2646] Refactor GuiSelector, use layout attributes for Weapons beam and shields#2647
Open
oznogon wants to merge 4 commits intodaid:masterfrom
Open
[#2497, #2642, #2643, #2646] Refactor GuiSelector, use layout attributes for Weapons beam and shields#2647oznogon wants to merge 4 commits intodaid:masterfrom
oznogon wants to merge 4 commits intodaid:masterfrom
Conversation
Contributor
Author
|
Translators will probably have issues with this that I can't anticipate, and I'd appreciate feedback. Most space-constrained text fields have a worse time in other languages, French in particular. |
- Add overridePopupWidth() function to manually set a minimum width for the popup list of options. - Scale button height and text size of popup list options if they overflow the screen height, as it does with frequency lists for beams/shields. - Clip text to the space between the arrow buttons. - Remove redundant sound effects from arrow button clicks, which are already handled by onMouseUp on the entire GuiSelector rect.
- Add shield controls to the adjacent beam info controls GuiElement container. - Use layout attributes in beam info controls container. - Add labels for beam frequency and beam system target. - Dynamically resize elements and change labels to avoid radar overlap. - Rename beam section to "Beam targeting" to better reflect its purpose. - Use GuiSelector::overridePopupWidth() to widen popup and better fit long system names, such as "Front Shield Generator". - Add label for shield controls.
761be89 to
7e56044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuiSelector:
Weapons:
Before:
Screencast_20251223_021256.webm
After:
Screencast_20251223_020441.webm