Repository navigation
(Claude) Reformat JS, CSS, JSON and YAML with oxfmt - #357
Merged
Merged
Conversation
The output of `just fmt-js` (oxfmt 0.69.0 with .oxfmtrc.json, plus scripts/fmt_templates.py for the component files holding Jinja), and nothing else: no hand edits. Meaning is unchanged: the JS parses to equal ASTs, the CSS is equal once whitespace, quote style, hex case and leading zeros are normalized, and the YAML and JSON load to equal data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`just update-snapshot` after the reformat. All 16 HTML blocks change, with the same names, and every change is inside <style> or <script>: with those stripped, each block equals its previous version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (28)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request reformats workflow configuration and HTML template CSS and JavaScript. The supplied summaries report no runtime behavior changes. ChangesFormatting normalization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The formatting changes appear mergeable after normal checks; no actionable issue remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 30.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 9 files. (17 skipped: 17 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.14)claude_code_log/html/templates/components/minimal/minimal.jsFile contains syntax errors that prevent linting: Line 13: Expected a statement but instead found '% include 'components/minimal/scheme.js' %'. claude_code_log/html/templates/components/minimal/pages.jsFile contains syntax errors that prevent linting: Line 7: Expected a statement but instead found '% include 'components/minimal/scheme.js' %'. claude_code_log/html/templates/components/minimal/theme_init.jsFile contains syntax errors that prevent linting: Line 1: Expected a statement but instead found '% include 'components/minimal/scheme_init.js' %'. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cboos
added a commit
that referenced
this pull request
Oct 9, 2026
`just fmt-check` joins `just ci`, and CI runs the same two checks on the primary job, after lint-js; both run, so every unformatted file is listed. `.git-blame-ignore-revs` names the reformat commit (#357), and CONTRIBUTING says how to point `git blame` at it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reformat planned in #356: the output of
just fmt-js, with nothing edited by hand, and the HTML snapshots regenerated to match.What changes
test_snapshot_html.ambrThese are the figures #356 announced. Most of the JavaScript churn is indentation: the component files were indented to sit inside the templates'
<script>blocks, and oxfmt starts them at column 0.git diff -wleaves +745/−227. The four component files that hold Jinja were formatted throughscripts/fmt_templates.py, and their Jinja lines are unchanged.Meaning is unchanged
Each file was compared between
mainand this branch:yaml.safe_loadgives equal data, and the comment lines and anchors are unchanged..vscode/settings.jsonlost a trailing comma, which VS Code's JSONC never needed.Each comparison was also checked against a deliberate one-character change in its format, which it flagged.
In the snapshots, all 16 HTML blocks change, with the same names, and every change is inside
<style>or<script>: strip those and each block equals its previous version. The Markdown snapshot is untouched.just fmt-checkandjust lint-jspass, and so doesjust ci.Next
A follow-up PR adds this PR's merge commit to
.git-blame-ignore-revs, sogit blamelooks through it, and runsjust fmt-checkinjust ciand on CI's primary job. It needs this PR's SHA onmain, so it comes after the merge.🤖 Generated with Claude Code
Summary by CodeRabbit