webdav/frontend: update rate limiter to respond with Retry-After header#8131
Merged
Conversation
Motivation: The rfc6585 suggest that server MAY include Retry-After header, which is used by FTS. So, let's be a good citizen and do so. Modification: Update RateLimitedHandlerList to provide Retry-After header. For blocked clients an initial blocking time and blocking duration is used. For general rate limiting a random value between 1 and client idle window is used. Result: FTS friendly behaviour Issue: #8102 Acked-by: Lennart Sack Target: master, 11.2 Require-book: no Require-notes: yes (cherry picked from commit 5ff074d) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The rfc6585 suggest that server MAY include Retry-After header, which is used by FTS. So, let's be a good citizen and do so.
Modification:
Update RateLimitedHandlerList to provide Retry-After header. For blocked clients an initial blocking time and blocking duration is used. For general rate limiting a random value between 1 and client idle window is used.
Result:
FTS friendly behaviour
Issue: #8102
Acked-by: Lennart Sack
Target: master, 11.2
Require-book: no
Require-notes: yes
(cherry picked from commit 5ff074d)