Skip to content

Unpack list-conversation entries in get_list_tweets #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruizie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unpack list-conversation entries in get_list_tweets #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions twikit/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3596,14 +3596,19 @@ async def get_list_tweets(
next_cursor = items[-1]['content']['value']

results = []
for item in items:
if not item['entryId'].startswith('tweet'):
continue

def handle_item(item):
tweet = tweet_from_data(self, item)
if tweet is not None:
results.append(tweet)

for item in items:
if item['entryId'].startswith('tweet'):
handle_item(item)
elif item['entryId'].startswith('list-conversation'):
for item in item['content']['items']:
handle_item(item)
Comment on lines +3608 to +3610

@sourcery-ai sourcery-ai Bot Mar 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid shadowing the 'item' variable in the inner loop.

The inner loop reuses the name 'item' which shadows the outer 'item'. This could lead to confusion when reading the code. Consider renaming the inner loop variable (e.g., to 'sub_item') for clarity.

Suggested change
elif item['entryId'].startswith('list-conversation'):
for item in item['content']['items']:
handle_item(item)
elif item['entryId'].startswith('list-conversation'):
for sub_item in item['content']['items']:
handle_item(sub_item)


return Result(
results,
partial(self.get_list_tweets, list_id, count, next_cursor),
Expand Down