Save files continuously when batch scanning - #894
Open
gormster wants to merge 2 commits into
Open
Conversation
added 2 commits
July 20, 2026 18:04
This changes the batch scan operation to use AsyncIterable throughout, meaning files are saved continuously. This means significantly reduced memory usage as well as allowing faster workflows for apps that read from the scan destination folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch scanning has several options for splitting output files, but the current implementation stores all images in memory until the entire scan is complete. This change creates files as they are scanned and meet the split condition, by replacing the separate
InputandOutputstages with anInputIterasync iterator function and anOutputIterfunction that consumes it continuously.Our use case is scanning documents which are continuously processed by another system which monitors an output directory; forcing the system to wait until the scan is complete before it can start processing causes significant wasted time as the processing system idles waiting for NAPS2 to complete the scan before writing the image files. With this modification, the scanning and processing systems can operate in parallel.