Conversation
Use of "*" basedir implemented. This allows to navigate to PC drives on windows based server.
Revert previous old repo changes
Owner
|
Without actually testing it, you could probably use UNC paths to accomplish something similar without modifying the software in this way. As a general rule of thumb, it is fairly dangerous to expose the entire physical file system of an OS to a web browser without applying appropriate protections (minimally login + XSRF tokens). In my extensive experience, people tend to lack good security hygiene, so I'm generally against these sort of changes no matter how cool they might seem on the surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I made these changes for a work project and I'm sharing them in case they can be useful.
The changes allow you to browse Windows drives through the file explorer (see screenshot).
The use of basedir="*" enables the feature.