Updated model to ifdo version 2.2.0#16
Open
GermanHydrogen wants to merge 4 commits intocsiro-fair:mainfrom
Open
Updated model to ifdo version 2.2.0#16GermanHydrogen wants to merge 4 commits intocsiro-fair:mainfrom
GermanHydrogen wants to merge 4 commits intocsiro-fair:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Updated
Note
I did not add type to the attribute documentation of the
ImageStereoCameraCalibrationModel, as they would have made the line to long.Are they really necessary in the first place? We already supply type annotations to the attribute the themself, and adding them to the doc-string feels redundant. They also may lead to misinformation, as only the type annotations are type-checked and not the doc-strings.