Skip to content

Add a PHPStan check for PHP 8.4 and 8.5 - #18

Merged
csev merged 2 commits into
masterfrom
phpstan-php-8.4-8.5
Oct 23, 2026
Merged

csev merged 2 commits into
masterfrom
phpstan-php-8.4-8.5

Conversation

@csev

@csev csev commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Run PHPStan in GitHub Actions for PHP 8.4 and 8.5. The job checks out Tsugi for class symbols and does not start a web server.
  • Fix the undefined variables and extra function arguments the analysis found, and stop a few files from emitting whitespace after a closing PHP tag.
  • Leave Tsugi's own deprecated Settings, ltiCustomGet(), and Koseu application calls out of the report.

Test plan

  • Confirm the PHPStan workflow runs and passes on this pull request
  • Locally, with a tsugi/ checkout present, run composer install and composer phpstan

csev and others added 2 commits October 23, 2026 10:51
Co-authored-by: Cursor <cursoragent@cursor.com>
@csev
csev merged commit 29bd709 into master Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant