fix: support forkserver multiprocessing start method (Python 3.14+)#396
Open
LittleLightLittleFire wants to merge 1 commit intocs50:mainfrom
Open
fix: support forkserver multiprocessing start method (Python 3.14+)#396LittleLightLittleFire wants to merge 1 commit intocs50:mainfrom
LittleLightLittleFire wants to merge 1 commit intocs50:mainfrom
Conversation
Python 3.14 changed the default multiprocessing start method on Linux from "fork" to "forkserver". The _store_attributes guard only passed cross-process state for "spawn", leaving "forkserver" children with None for run_root_dir and other attributes. Invert the condition to only skip for "fork", which is the only method that inherits full parent memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 changed the default multiprocessing start method on Linux from "fork" to "forkserver". The _store_attributes guard only passed cross-process state for "spawn", leaving "forkserver" children with None for run_root_dir and other attributes.
Invert the condition to only skip for "fork", which is the only method that inherits full parent memory.